Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - BigInt #121

Closed
jasonwilliams opened this issue Sep 27, 2019 · 7 comments · Fixed by #358
Closed

[Feature] - BigInt #121

jasonwilliams opened this issue Sep 27, 2019 · 7 comments · Fixed by #358
Assignees
@HalidOdat
Labels
enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Milestone
v0.8.0

Comments

@jasonwilliams
Copy link
Member

https://tc39.es/ecma262/#sec-bigint-objects
@jasonwilliams jasonwilliams added the enhancement New feature or request label Sep 27, 2019
@jasonwilliams
Copy link
Member Author

Sure, go for it!

@jasonwilliams jasonwilliams added the Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com label Oct 8, 2019
@jasonwilliams
Copy link
Member Author

jasonwilliams commented Oct 11, 2019 •
edited
Loading

@tiagolisalves while you're in there, you mind looking at this too?
https://github.com/jasonwilliams/boa/blob/master/src/lib/syntax/lexer.rs#L395

It shouldn't need unwrap

@HalidOdat
Copy link
Member

HalidOdat commented Apr 23, 2020 •
edited
Loading

If nobody is working on this, I would like to implement it. :)

@tiagolisalves tiagolisalves removed their assignment Apr 23, 2020
@HalidOdat HalidOdat self-assigned this Apr 23, 2020
@HalidOdat HalidOdat added this to the v0.8.0 milestone Apr 24, 2020
@HalidOdat HalidOdat mentioned this issue May 1, 2020
Merged
@Razican
Copy link
Member

Razican commented May 14, 2020

Should this still go in 0.8?

@HalidOdat
Copy link
Member

HalidOdat commented May 14, 2020 •
edited
Loading

Should this still go in 0.8?

I should be done with BigInt #358 by today or tomorrow, I've been really busy this week so progress has been slow.

@jasonwilliams
Copy link
Member Author

Should this still go in 0.8?

I don’t have strong opinions either way

@Razican
Copy link
Member

Razican commented May 14, 2020

I should be done with BigInt #358 by today or tomorrow, I've been really busy this week so progress has been slow.

Ok, so I would say to add it, as it was initially planned for this version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HalidOdat HalidOdat

Labels
enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Feature BigInt boa-dev/boa
4 participants
@Razican @jasonwilliams @tiagolisalves @HalidOdat