HTTPHost would not be overwritten by --http.addr if config.toml being used

[jasonyic]

System information

Geth version: v1.1.11
OS & Version: Linux

Expected behaviour

config.toml:

[Node]
DataDir = "node"
InsecureUnlockAllowed = false
NoUSB = true
IPCPath = "geth.ipc"
HTTPHost = "127.0.0.1"

geth --config config.toml --http.addr 0.0.0.0 --http.port 8545 would expect RPC listening on 0.0.0.0

Actual behaviour

RPC is listening on 127.0.0.1, still using the value set in config.toml

INFO [07-15|05:53:19.192] HTTP server started                      endpoint=127.0.0.1:8545 prefix= cors= vhosts=*

Backtrace

HTTPHost is set by config.toml and would not be overwritten by --http.addr

	if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {
		cfg.HTTPHost = "127.0.0.1"
		if ctx.GlobalIsSet(HTTPListenAddrFlag.Name) {
			cfg.HTTPHost = ctx.GlobalString(HTTPListenAddrFlag.Name)
		}
	}

Suggest/Fix

default HTTPHost in config.toml in each release should be kept as empty string ""

[yutianwu]

Hi, this issue will be fixed in #999, and it should be included in the next release.

[jasonyic]

thank you