diff --git a/widget_driver_generator/CHANGELOG.md b/widget_driver_generator/CHANGELOG.md index 34a97f5..489e405 100644 --- a/widget_driver_generator/CHANGELOG.md +++ b/widget_driver_generator/CHANGELOG.md @@ -1,5 +1,9 @@ # CHANGELOG +## 1.3.1 + +* fixes bug where the "void" keyword was unnecessarily added to setters. + ## 1.3.0 * Introduces the option to specify formatter line length in build.yaml. diff --git a/widget_driver_generator/lib/src/code_providers/test_driver_code_provider.dart b/widget_driver_generator/lib/src/code_providers/test_driver_code_provider.dart index dfaf0a8..7d73161 100644 --- a/widget_driver_generator/lib/src/code_providers/test_driver_code_provider.dart +++ b/widget_driver_generator/lib/src/code_providers/test_driver_code_provider.dart @@ -49,7 +49,7 @@ class $_testDriverClassName extends TestDriver implements $_driverClassName { final List properties = []; final getProperties = _getProperties.map((e) => _getComputedPropertyCode(e.codeDefinition, e.returnValue)); properties.addAll(getProperties); - final setProperties = _setProperties.map((e) => _getMethodCode(e.codeDefinition, e.returnValue)); + final setProperties = _setProperties.map((e) => _getSetterCode(e.codeDefinition, e.returnValue)); properties.addAll(setProperties); return properties.join(doubleEmptyLine); } @@ -126,6 +126,13 @@ $methodDefinition { return sourceCode; } + /// Returns the code needed to implement an override of a setter. + String _getSetterCode(String methodDefinition, String returnValue) { + // keeping void will upset dart analyzer + final sanitizedCodeDefinition = methodDefinition.replaceFirst('void ', ''); + return _getMethodCode(sanitizedCodeDefinition, returnValue); + } + String get emptyLineCode => '\n'; String get doubleEmptyLine => emptyLineCode + emptyLineCode; } diff --git a/widget_driver_generator/pubspec.yaml b/widget_driver_generator/pubspec.yaml index da2b65e..594a51e 100644 --- a/widget_driver_generator/pubspec.yaml +++ b/widget_driver_generator/pubspec.yaml @@ -1,6 +1,6 @@ name: widget_driver_generator description: This package provides generators for WidgetDriver to automate the creation of your TestDrivers and WidgetDriverProviders -version: 1.3.0 +version: 1.3.1 repository: https://github.com/bmw-tech/widget_driver/tree/master/widget_driver_generator issue_tracker: https://github.com/bmw-tech/widget_driver/issues diff --git a/widget_driver_generator/test/code_providers/test_driver_code_provider_test.dart b/widget_driver_generator/test/code_providers/test_driver_code_provider_test.dart index fa7c2ae..a741019 100644 --- a/widget_driver_generator/test/code_providers/test_driver_code_provider_test.dart +++ b/widget_driver_generator/test/code_providers/test_driver_code_provider_test.dart @@ -139,7 +139,7 @@ class _\$TestExampleDriver extends TestDriver implements ExampleDriver { @override -void set example(String newExample) {} +set example(String newExample) {} } @@ -163,10 +163,10 @@ class _\$TestExampleDriver extends TestDriver implements ExampleDriver { @override -void set example(String newExample) {} +set example(String newExample) {} @override -void set example2(String newExample2) {} +set example2(String newExample2) {} } @@ -263,10 +263,10 @@ String get example => ''; String get example2 => ''; @override -void set example(String newExample) {} +set example(String newExample) {} @override -void set example2(String newExample2) {} +set example2(String newExample2) {} @override String example() {