forked from rust-lang/rust-clippy
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathimplicit_saturating_sub.rs
281 lines (220 loc) · 4.16 KB
/
implicit_saturating_sub.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
#![allow(unused_assignments, unused_mut, clippy::assign_op_pattern)]
#![warn(clippy::implicit_saturating_sub)]
use std::cmp::PartialEq;
use std::ops::SubAssign;
// Mock type
struct Mock;
impl PartialEq<u32> for Mock {
fn eq(&self, _: &u32) -> bool {
true
}
}
impl SubAssign<u32> for Mock {
fn sub_assign(&mut self, _: u32) {}
}
fn main() {
// Tests for unsigned integers
let end_8: u8 = 10;
let start_8: u8 = 5;
let mut u_8: u8 = end_8 - start_8;
// Lint
if u_8 > 0 {
u_8 = u_8 - 1;
}
match end_8 {
10 => {
// Lint
if u_8 > 0 {
u_8 -= 1;
}
},
11 => u_8 += 1,
_ => u_8 = 0,
}
let end_16: u16 = 40;
let start_16: u16 = 35;
let mut u_16: u16 = end_16 - start_16;
// Lint
if u_16 > 0 {
u_16 -= 1;
}
let mut end_32: u32 = 7010;
let mut start_32: u32 = 7000;
let mut u_32: u32 = end_32 - start_32;
// Lint
if u_32 != 0 {
u_32 -= 1;
}
// No Lint
if u_32 > 0 {
u_16 += 1;
}
// No Lint
if u_32 != 0 {
end_32 -= 1;
start_32 += 1;
}
let mut end_64: u64 = 75001;
let mut start_64: u64 = 75000;
let mut u_64: u64 = end_64 - start_64;
// Lint
if u_64 > 0 {
u_64 -= 1;
}
// Lint
if 0 < u_64 {
u_64 -= 1;
}
// Lint
if 0 != u_64 {
u_64 -= 1;
}
// No Lint
if u_64 >= 1 {
u_64 -= 1;
}
// No Lint
if u_64 > 0 {
end_64 -= 1;
}
// Tests for usize
let end_usize: usize = 8054;
let start_usize: usize = 8050;
let mut u_usize: usize = end_usize - start_usize;
// Lint
if u_usize > 0 {
u_usize -= 1;
}
// Tests for signed integers
let endi_8: i8 = 10;
let starti_8: i8 = 50;
let mut i_8: i8 = endi_8 - starti_8;
// Lint
if i_8 > i8::MIN {
i_8 -= 1;
}
// Lint
if i_8 > i8::MIN {
i_8 -= 1;
}
// Lint
if i_8 != i8::MIN {
i_8 -= 1;
}
// Lint
if i_8 != i8::MIN {
i_8 -= 1;
}
let endi_16: i16 = 45;
let starti_16: i16 = 44;
let mut i_16: i16 = endi_16 - starti_16;
// Lint
if i_16 > i16::MIN {
i_16 -= 1;
}
// Lint
if i_16 > i16::MIN {
i_16 -= 1;
}
// Lint
if i_16 != i16::MIN {
i_16 -= 1;
}
// Lint
if i_16 != i16::MIN {
i_16 -= 1;
}
let endi_32: i32 = 45;
let starti_32: i32 = 44;
let mut i_32: i32 = endi_32 - starti_32;
// Lint
if i_32 > i32::MIN {
i_32 -= 1;
}
// Lint
if i_32 > i32::MIN {
i_32 -= 1;
}
// Lint
if i_32 != i32::MIN {
i_32 -= 1;
}
// Lint
if i_32 != i32::MIN {
i_32 -= 1;
}
let endi_64: i64 = 45;
let starti_64: i64 = 44;
let mut i_64: i64 = endi_64 - starti_64;
// Lint
if i64::MIN < i_64 {
i_64 -= 1;
}
// Lint
if i64::MIN != i_64 {
i_64 -= 1;
}
// Lint
if i64::MIN < i_64 {
i_64 -= 1;
}
// No Lint
if i_64 > 0 {
i_64 -= 1;
}
// No Lint
if i_64 != 0 {
i_64 -= 1;
}
// issue #7831
// No Lint
if u_32 > 0 {
u_32 -= 1;
} else {
println!("side effect");
}
// Extended tests
let mut m = Mock;
let mut u_32 = 3000;
let a = 200;
let mut b = 8;
if m != 0 {
m -= 1;
}
if a > 0 {
b -= 1;
}
if 0 > a {
b -= 1;
}
if u_32 > 0 {
u_32 -= 1;
} else {
println!("don't lint this");
}
if u_32 > 0 {
println!("don't lint this");
u_32 -= 1;
}
if u_32 > 42 {
println!("brace yourself!");
} else if u_32 > 0 {
u_32 -= 1;
}
let result = if a < b {
println!("we shouldn't remove this");
0
} else {
a - b
};
}
// https://github.com/rust-lang/rust-clippy/issues/13524
fn regression_13524(a: usize, b: usize, c: bool) -> usize {
if c {
123
} else if a >= b {
0
} else {
b - a
}
}