Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder for Uptime details > History table in case there is no data #1671

Closed
gorkem-bwl opened this issue Jan 31, 2025 · 5 comments
Assignees
Labels
design Design related frontend good first issue Good for newcomers

Comments

@gorkem-bwl
Copy link
Contributor

Under uptime details, when the history table has no data, do not show the header of the table, but instead write "There is no incident history for this monitor." in the center.

Image
@gorkem-bwl gorkem-bwl added design Design related frontend good first issue Good for newcomers labels Jan 31, 2025
@gorkem-bwl gorkem-bwl added this to the 2.1 milestone Jan 31, 2025
@ajhollid ajhollid self-assigned this Jan 31, 2025
@ajhollid
Copy link
Collaborator

@gorkem-bwl I believe I have resolved this one already, I may not have pushed it to the test server, I will double check tomorrow morning!

@gorkem-bwl
Copy link
Contributor Author

Sure, keeping this open for now then.

@ajhollid
Copy link
Collaborator

ajhollid commented Jan 31, 2025

@gorkem-bwl so I had a look and placeholders are not implemented for this page yet. How is this for an empty view?

Image

That's consistent with other empty views in the app.

Also a note the table at the bottom of the Details page is not an incidents table, it shows all checks, up or down, so there will never be a case where the page should show other data but an empty table. If there are no checks, nothing should be shown at all.

@gorkem-bwl
Copy link
Contributor Author

@gorkem-bwl so I had a look and placeholders are not implemented for this page yet. How is this for an empty view?

Image

That's consistent with other empty views in the app.

Also a note the table at the bottom of the Details page is not an incidents table, it shows all checks, up or down, so there will never be a case where the page should show other data but an empty table. If there are no checks, nothing should be shown at all.

OK, understood. Then can we rename it "Check history" ?

@ajhollid
Copy link
Collaborator

ajhollid commented Feb 1, 2025

Can do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants