Skip to content

Commit 0b3cd9e

Browse files
committed
Add empty veiw to PageSpeed Details, fix config path
1 parent 2ba2e49 commit 0b3cd9e

File tree

2 files changed

+31
-9
lines changed

2 files changed

+31
-9
lines changed

Client/src/Pages/PageSpeed/Details/index.jsx

+27-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
// Components
2-
import { Stack, Typography, Skeleton } from "@mui/material";
2+
import { Stack, Typography } from "@mui/material";
33
import Breadcrumbs from "../../../Components/Breadcrumbs";
4+
import MonitorTimeFrameHeader from "../../../Components/MonitorTimeFrameHeader";
45
import MonitorStatusHeader from "../../../Components/MonitorStatusHeader";
56
import PageSpeedStatusBoxes from "./Components/PageSpeedStatusBoxes";
67
import PageSpeedAreaChart from "./Components/PageSpeedAreaChart";
78
import PerformanceReport from "./Components/PerformanceReport";
9+
import GenericFallback from "../../../Components/GenericFallback";
810
// Utils
911
import { useTheme } from "@emotion/react";
1012
import { useIsAdmin } from "../../../Hooks/useIsAdmin";
@@ -41,10 +43,28 @@ const PageSpeedDetails = () => {
4143
setMetrics((prev) => ({ ...prev, [id]: !prev[id] }));
4244
};
4345

46+
// Empty view, displayed when loading is complete and there are no checks
47+
if (!isLoading && monitor?.checks?.length === 0) {
48+
return (
49+
<Stack gap={theme.spacing(10)}>
50+
<Breadcrumbs list={BREADCRUMBS} />
51+
<MonitorStatusHeader
52+
path={"pagespeed"}
53+
isAdmin={isAdmin}
54+
monitor={monitor}
55+
/>
56+
<GenericFallback>
57+
<Typography>There is no history for this monitor yet.</Typography>
58+
</GenericFallback>
59+
</Stack>
60+
);
61+
}
62+
4463
return (
4564
<Stack gap={theme.spacing(10)}>
4665
<Breadcrumbs list={BREADCRUMBS} />
4766
<MonitorStatusHeader
67+
path={"pagespeed"}
4868
isAdmin={isAdmin}
4969
shouldRender={!isLoading}
5070
monitor={monitor}
@@ -53,12 +73,12 @@ const PageSpeedDetails = () => {
5373
shouldRender={!isLoading}
5474
monitor={monitor}
5575
/>
56-
<Typography
57-
variant="body2"
58-
my={theme.spacing(8)}
59-
>
60-
Showing statistics for past 24 hours.
61-
</Typography>
76+
<MonitorTimeFrameHeader
77+
shouldRender={!isLoading}
78+
dateRange={"day"}
79+
hasDateRange={false}
80+
/>
81+
6282
<PageSpeedAreaChart
6383
shouldRender={!isLoading}
6484
monitor={monitor}

Client/src/Pages/Uptime/Details/index.jsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Components
22
import Breadcrumbs from "../../../Components/Breadcrumbs";
33
import MonitorStatusHeader from "../../../Components/MonitorStatusHeader";
4-
import TimeFramePicker from "./Components/TimeFramePicker";
4+
import MonitorTimeFrameHeader from "../../../Components/MonitorTimeFrameHeader";
55
import ChartBoxes from "./Components/ChartBoxes";
66
import ResponseTimeChart from "./Components/Charts/ResponseTimeChart";
77
import ResponseTable from "./Components/ResponseTable";
@@ -81,6 +81,7 @@ const UptimeDetails = () => {
8181
<Stack gap={theme.spacing(10)}>
8282
<Breadcrumbs list={BREADCRUMBS} />
8383
<MonitorStatusHeader
84+
path={"uptime"}
8485
isAdmin={isAdmin}
8586
shouldRender={!monitorIsLoading}
8687
monitor={monitor}
@@ -90,8 +91,9 @@ const UptimeDetails = () => {
9091
monitor={monitor}
9192
certificateExpiry={certificateExpiry}
9293
/>
93-
<TimeFramePicker
94+
<MonitorTimeFrameHeader
9495
shouldRender={!monitorIsLoading}
96+
hasDateRange={true}
9597
dateRange={dateRange}
9698
setDateRange={setDateRange}
9799
/>

0 commit comments

Comments
 (0)