Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replace deprecated np.round_ with np.round function #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Replace deprecated np.round_ with np.round function #76

wants to merge 2 commits into from
+3 −3

Conversation

Thanos-png
Copy link

@Thanos-png Thanos-png commented Mar 6, 2025 •
edited
Loading

Fixes #75

Changes

  • Resolves the NumPy 2.0+ deprecation warning by replacing the deprecated np.round_ with the recommended np.round function.
  • Fixed style issue in test_intensity_array to use isinstance() instead of type comparison

Testing

All tests related to the round() method pass successfully:

  • test_round_no_merge
  • test_round_merge_len
  • test_round_merge_sum
  • test_round_merge_max

@Thanos-png Thanos-png closed this Mar 6, 2025
@Thanos-png Thanos-png reopened this Mar 6, 2025
@Thanos-png
Copy link
Author

Hi! This is my first PR, so please let me know if I need to adjust anything. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated np.round_ in NumPy ≥ 2.0
1 participant
@Thanos-png