Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster FragmentAnnotation equality check #73

Open
bittremieux opened this issue Nov 24, 2024 · 3 comments
Open

Faster FragmentAnnotation equality check #73

bittremieux opened this issue Nov 24, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bittremieux
Copy link
Member

bittremieux commented Nov 24, 2024

Checking whether two FragmentAnnotations are equal is slow due to the regex comparison in __str__ . The regex can be compiled or more direct equality checking can be implemented.

It's important to benchmark the runtime of the old implementation versus any optimized implementation.

@bittremieux bittremieux added the enhancement New feature or request label Nov 24, 2024
@bittremieux
Copy link
Member Author

Please don't hijack issues with unrelated questions. We are busily preparing additional information for interested GSoC contributors.

@bittremieux bittremieux added the good first issue Good for newcomers label Mar 4, 2025
@dikshant182004
Copy link

hi @bittremieux ,i have understood all your sayings and it will not be repeated in future.however ,for the time being can i contribute in this issue

@bittremieux
Copy link
Member Author

Yes, this would certainly be a good issue to start contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants