Merge pull request #155 from bitshares/nathanhourt-fix-logger-warnings

nathanielhourt · web-flow · commit 7954c4a9c001 · 2019-08-29T13:11:25.000-05:00
Fix warnings (ref bitshares/bitshares-core#1584)
diff --git a/include/fc/log/appender.hpp b/include/fc/log/appender.hpp
@@ -34,6 +34,7 @@ namespace fc {
             return register_appender( type, appender_factory::ptr( new detail::appender_factory_impl<T>() ) );
          }
 
+         virtual ~appender() = default;
          static appender::ptr create( const std::string& name, const std::string& type, const variant& args  );
          static appender::ptr get( const std::string& name );
          static bool          register_appender( const std::string& type, const appender_factory::ptr& f );

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ namespace fc {`
`34`	`34`	`return register_appender( type, appender_factory::ptr( new detail::appender_factory_impl<T>() ) );`
`35`	`35`	`}`
`36`	`36`
	`37`	`+ virtual ~appender() = default;`
`37`	`38`	`static appender::ptr create( const std::string& name, const std::string& type, const variant& args );`
`38`	`39`	`static appender::ptr get( const std::string& name );`
`39`	`40`	`static bool register_appender( const std::string& type, const appender_factory::ptr& f );`