CLI wallet history API is broken

[vikramrajkumar]

From @theoreticalbts on September 18, 2015 20:3

CLI wallet history API only allows getting the last 100 entries in history -- there is no way to specify a starting point.

Copied from original issue: cryptonomex/graphene#326

[oxarbitrage]

Not broken, at least not in the last version. Getting more than 100 entries is possible, here i get the last 200 operations from a user using the cli wallet as client:

unlocked >>> get_account_history nyse 200
get_account_history nyse 200
2017-02-28T16:51:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952612 
2017-02-28T16:51:27 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 1461.12397 BTS 
2017-02-28T16:48:24 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952606 
2017-02-28T16:48:24 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 6220.05321 BTS 
2017-02-28T16:47:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952601 
2017-02-28T16:47:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952600 
2017-02-28T16:47:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952599 
2017-02-28T16:47:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952598 
2017-02-28T16:47:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952597 
2017-02-28T16:47:27 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 32.5023 CRYPTOCEEDS 
2017-02-28T16:47:27 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 150 CNY 
2017-02-28T16:47:27 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 3110.04184 BTS 
...
2017-02-28T15:37:33 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 65.64651 BTS 
2017-02-28T15:37:33 limit_order_cancel_operation nyse fee: 0.01467 BTS   result: 58.98021 BTS 
2017-02-28T15:37:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951714 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951696 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951695 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951694 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951693 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951692 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951691 
2017-02-28T15:37:21 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1951690

Need the last 500, no problem:

unlocked >>> get_account_history nyse 500
get_account_history nyse 500
2017-02-28T16:51:27 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1952612 
...
2017-02-28T15:19:30 fill_order_operation nyse fee: 0 CNY 
2017-02-28T15:19:30 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1949963 
2017-02-28T15:19:30 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1949962 
2017-02-28T15:19:30 limit_order_create_operation nyse fee: 0.14676 BTS   result: 1.7.1949961

It is true that you can't set up a starting point but it is also true that the wallet is available to get more than 100 operations with the get_account_history call.

If a start parameter is needed please let me know i can also add but first need to know if it is really needed.

[oxarbitrage]

#277

[abitmore]

Fixed.