Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting into smaller libraries? #57

Closed
greggman opened this issue Jan 12, 2016 · 1 comment
Closed

Splitting into smaller libraries? #57

greggman opened this issue Jan 12, 2016 · 1 comment

Comments

@greggman
Copy link

I was using launchpad to launch a local browser. I upgraded recently because sys is deprecated and I was hoping that was fixed. Instead I found that launchpad now uses restify which now uses DTRACE which now makes it incompatible with my usecase.

That got me wondering, why are all these things conflated? I certainly don't need any kind of REST api for launching a browser. I also don't need to launch browserstack or remote browsers. It would be awesome if launchpad was split into some top level API and plugins for the various backends such that a user can install only the parts they need (in my case local browsers only). That would remove tons of dependencies and make it more useful for more people.

@daffl
Copy link
Contributor

daffl commented Jan 13, 2016

You are right, I've been meaning to pull out the launchpad server for a while because it really doesn't belong in here.

I'm always a fan of small modules but in this case I am not sure if more modularization than that is really necessary. I usually base the decision off two things: code-base size (which I think in this case with ~500 LOC is manageable) and unnecessary dependencies (which here is potentially only the Browserstack client - a very small module with no dependencies on it's own).

@daffl daffl closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants