Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOCALAPPDATA not always present? #28

Closed
greggman opened this issue Aug 7, 2014 · 1 comment
Closed

LOCALAPPDATA not always present? #28

greggman opened this issue Aug 7, 2014 · 1 comment

Comments

@greggman
Copy link

greggman commented Aug 7, 2014

I don't know why by my XP has no LOCALAPPDATA env var. It only has APPDATA

Sorry I don't have a patch (made too many changes before I found the issue).

basically in windows.js at the top I added

var appData = process.env.LOCALAPPDATA || process.env.APPDATA;

And then changed all other references of process.env.LOCALAPPDATA to appData.

Also, and I'm guessing you know this but

function getPath() {
  return path.join.apply(path, arguments);
}

can just be

var getPath = path.join.bind(path);

if you prefer.

@daffl
Copy link
Contributor

daffl commented Nov 3, 2014

Closed via #32.

@daffl daffl closed this as completed Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants