Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote server should replace localhost with request ip #18

Closed
daffl opened this issue Sep 9, 2013 · 1 comment
Closed

Remote server should replace localhost with request ip #18

daffl opened this issue Sep 9, 2013 · 1 comment

Comments

@daffl
Copy link
Contributor

daffl commented Sep 9, 2013

If a client launches a remote browser e.g. like

launch.remote('http://localhost:8080/test.html', { browser: 'safari' })

We should replace localhost with the origin requests IP address. I think we are fairly safe to assume that localhost means the requesting machine, not the remote system itself.

/cc @alexisabril
@ekryski
Copy link
Contributor

ekryski commented Sep 9, 2013

+1

@alexisabril alexisabril mentioned this issue Sep 12, 2013
Merged
@daffl daffl closed this as completed in 29b7cc8 Sep 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @ekryski