Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/phpmyadmin] phpmyadmin fix default probes #2640

Merged
merged 2 commits into from
May 22, 2020

Conversation

dani8art
Copy link
Contributor

Description of the change

When successThreshold or failureThreshold are not set, the probes don't work.

NAME                          READY   STATUS    RESTARTS   AGE
phpmyadmin-6dc7f4f97-bhtrn    0/1     Running   6          7m53s
phpmyadmin-mariadb-master-0   1/1     Running   0          7m53s
phpmyadmin-mariadb-slave-0    1/1     Running   0          7m53s

Set by default some liveness and readiness probe values.

Benefits

We can deploy the chart with default values.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

Copy link
Contributor

@andresbono andresbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/phpmyadmin:5.0.2-debian-10-r63"
  • "docker.io/bitnami/apache-exporter:0.8.0-debian-10-r51"

@dani8art dani8art merged commit 81d7bc0 into master May 22, 2020
@dani8art dani8art deleted the phpmyadmin-fix-probes branch May 22, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants