Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #963 unintentional backwards compatibility break #1091

Closed
josvazg opened this issue Jan 23, 2023 · 5 comments · Fixed by #1118
Closed

PR #963 unintentional backwards compatibility break #1091

josvazg opened this issue Jan 23, 2023 · 5 comments · Fixed by #1118
Labels

Comments

@josvazg
Copy link
Collaborator

josvazg commented Jan 23, 2023

Which component:
Controller

Describe the bug
PR #963 introduced recreation of deleted secrets managed by the controller. To do that, it needed permissions to watch for secret changes. That new permission breaks in low-privilege / multi-tenant environments, such as the one described in #1064

This issue proposes to recover backward compatibility by gracefully falling back to pre PR #963 behavior when watch secrets permissions are not possible.

To Reproduce

See #1064

Expected behavior

Fail install if lacking permissions, instructing to use a new flag to explicitly skip watching.

@josvazg josvazg added the triage Issues/PRs that need to be reviewed label Jan 23, 2023
@agarcia-oss agarcia-oss added bug and removed triage Issues/PRs that need to be reviewed labels Jan 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the Stale label Feb 8, 2023
@alemorcuq alemorcuq removed the Stale label Feb 9, 2023
@github-actions
Copy link
Contributor

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the Stale label Feb 25, 2023
@abdennour
Copy link

@josvazg Do you mean drift management ?

@github-actions github-actions bot removed the Stale label Feb 28, 2023
@josvazg
Copy link
Collaborator Author

josvazg commented Feb 28, 2023

@abdennour can you elaborate what do you mean by drift management in this context?

Here we are just proposing to restore compatibility after we added some extra permission requirement that was not there before. The proposed solution is to fail if the missing permission is not allowed, but give the user a way to install by passing a explicit flag so that such permission is not required because secrets will not be watched, as happened in previous versions.

@josvazg
Copy link
Collaborator Author

josvazg commented Mar 1, 2023

BTW, I am picking this one up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants