Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently rust-bip39 only supports bip39 word counts divisible by 6 #226

Closed
notmandatory opened this issue Nov 9, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@notmandatory
Copy link
Member

Describe the bug

This issue is a reminder so we don't forget to fix this.

The WordCount enum allows users to pick word counts that aren't divisible by 6, but bdk is using the rust-bip39 crate which only allows word counts that are divisible by 6. See:

https://docs.rs/bip39/1.0.1/src/bip39/lib.rs.html#245-261

To Reproduce

Create a Mnemonic with WordCount of 15 words and an error is returned.

Expected behavior

When using the WordCount enum all the variants should be valid.

Build environment

  • BDK tag/commit: v0.11.0
  • OS+version: any
  • Rust/Cargo version: 1.60
  • Rust/Cargo target: any

Additional context

The next version of rust-bip39 should fix this issue with rust-bitcoin/rust-bip39#18.

This is the PR where bdk switched to using rust-bip39 bitcoindevkit/bdk#462

See also BIP-39.

@thunderbiscuit
Copy link
Member

This is resolved by bitcoindevkit/bdk#875.

@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK-Bindings Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants