Skip to content

Commit 6882828

Browse files
committed
Merge bitcoin/bitcoin#27318: test: wallet_create_tx.py fix race
8aab515 test: wallet_create_tx.py fix race (furszy) Pull request description: Fixes #27316 Because wallets are internally synchronized through the validation interface, and the interface dispatches events on a worker thread, it is possible for a transaction created by the first wallet to not arrive to the second wallet before the second wallet attempts to use one of its outputs. This is because we do not wait for the `BroadcastTransaction` callback during the wallet's "submit to mempool" process. To address this in the tests, we need to manually sync the validation queue. ACKs for top commit: josibake: ACK bitcoin/bitcoin@8aab515 theStack: ACK 8aab515 Tree-SHA512: 76364370ab292a5c3ea1ed61cd353fc626a9e9cd6ce18464c24da1b3dcb34b65006e2bc42b84bbd25af03f9449231990bf789504728972db3217b569099eb309
2 parents 2200086 + 8aab515 commit 6882828

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/functional/wallet_create_tx.py

+1
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ def test_create_too_long_mempool_chain(self):
9292
txid = tx_data['txid']
9393
vout = 1
9494

95+
self.nodes[0].syncwithvalidationinterfacequeue()
9596
options = {"change_position": 0, "add_inputs": False}
9697
for i in range(1, 25):
9798
options['inputs'] = [{'txid': txid, 'vout': vout}]

0 commit comments

Comments
 (0)