Skip to content

Commit c77a96d

Browse files
committed
Merge #369: doc: Update PR template, update documentation around CI artifacts
90048be doc: update documentation around CI artifacts (jarolrod) 572343c doc: update pr template (jarolrod) Pull request description: Update PR template and documentation for the move to github actions, also mentions the new need to make the macOS binary executable. ACKs for top commit: pablomartin4btc: ACK 90048be Tree-SHA512: a0a97ad37684be59367b49ea27e9776a961ec8cfeb7a0e323f5f6fb5d548df23b1aa3e7995645c315997db3676dedec60721b78bbfa43f319f11dca96ed7d377
2 parents 46e93de + 90048be commit c77a96d

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ patches often sit for a long time.
4343
-->
4444

4545
<!--
46-
Links for Windows and macOS build artifacts. Replace <PR> with the assigned pull request number.
46+
Link to github actions build artifacts.
47+
48+
[![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green
49+
)]()
4750
48-
[![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>)
49-
[![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>)
50-
[![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>)
51-
[![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>)
5251
-->

src/qml/README.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,13 @@
44

55
This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework.
66

7-
Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
8-
- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip)
9-
- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip)
10-
- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip)
11-
- for ARM64 Android: [`insecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip)
7+
Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build. These can be found under the [Actions](https://github.com/bitcoin-core/gui-qml/actions?query=branch%3Amain) tab. It is required to have and be logged into a github account in order to download these.
128

13-
Note: For Apple Silicon macOS machines, the binary must be signed before it can
14-
be ran. To apply a signature, run the following on the unzipped CI artifact:
9+
Note: For macOS, the CI artifact binary must be made executable and code-signed before it can
10+
be ran. To make executable and apply a signature, run the following on the unzipped CI artifact:
1511

1612
```
17-
codesign -s - ./Downloads/insecure_mac_arm64_gui
13+
chmod +x ./Downloads/bitcoin-qt && codesign -s - ./Downloads/bitcoin-qt
1814
```
1915

2016
## Goals and Limitations

0 commit comments

Comments
 (0)