Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 63 #1622

Closed
counterweightoperator opened this issue Sep 28, 2024 · 7 comments
Closed

For Cycle 63 #1622

counterweightoperator opened this issue Sep 28, 2024 · 7 comments
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone

Comments

@counterweightoperator
Copy link

counterweightoperator commented Sep 28, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 279.33
  • USD requested: 500
  • BSQ rate: 1.79 USD per BSQ
  • Previous compensation request (if applicable): #

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Review Spanish translations Growth 500 List below

Detail and comments

  • After noticing (1) missing strings in the ES translations, (2) ES translation strings that were actually in English, not in Spanish and (3) obviously wrong machine translations in the Bisq 2 project, I decided to give the project a review. Got carried away and reviewed all the property files for the project, translating what was missing, correcting was was wrong/improvable, and marking everything I went through as Reviewed in Transifex so the next translator can clearly identify what needs attention.
  • I'm confused as to whether this should be assigned to Growth or Dev, because of this and this PRs. Happy to correct if I got it wrong.
  • All my translations were merged into the repository in PRs.
  • I'm not including any date filter in the transifex screenshots since it was the first time I used it/was involved. hiciefte can vouch for that, since he gave me the access recently.
  • I tried to understand the compensation policies for translations from this wiki page and previous PRs. To be honest, some bits are confusing. I hope I did everything right, do let me know if I made any mistakes and I will happily correct the request.
  • I'm pasting below the table that explains where the requested 823.06USD are coming from.
  • I'm listing below all the related PRs and screenshots from Transifex.

Word counts

section Translated word count reviewed word count translation usd/word review usd/word translation amount review amount
academy 5885 5938 $0.07 0 $411.95 $0.00
application 257 537 $0.07 0 $17.99 $0.00
authorized_role 213 388 $0.07 0 $14.91 $0.00
bisq_easy 1946 2705 $0.07 0 $136.22 $0.00
chat 385 642 $0.07 0 $26.95 $0.00
default 96 197 $0.07 0 $6.72 $0.00
network 12 171 $0.07 0 $0.84 $0.00
payment_method 45 159 $0.07 0 $3.15 $0.00
settings 66 190 $0.07 0 $4.62 $0.00
trade_apps 2649 2872 $0.07 0 $185.43 $0.00
user 202 488 $0.07 0 $14.14 $0.00
wallet 2 31 $0.07 0 $0.14 $0.00
total 11758 14318     $823.06 $0.00

PRs and Transifex screenshots

https://i.postimg.cc/MpgtGjj6/academy-reviewed.png
https://i.postimg.cc/MGR5fKyy/academy-translated.png
https://i.postimg.cc/v8PrB6pJ/application-reviewed.png
https://i.postimg.cc/gJsv3wr6/application-translated.png
https://i.postimg.cc/J0hjx1BY/authorized-role-reviewed.png
https://i.postimg.cc/hv3T3HLD/authorized-role-translated.png
https://i.postimg.cc/yYt0hC6n/bisq-easy-reviewed.png
https://i.postimg.cc/BQXx1n3X/bisq-easy-translated.png
https://i.postimg.cc/BvGDy5KK/chat-reviewed.png
https://i.postimg.cc/vZnf32cy/chat-translated.png
https://i.postimg.cc/V6ftsY4s/default-reviewed.png
https://i.postimg.cc/bvHbjGxF/default-translated.png
https://i.postimg.cc/MHXjRdhh/network-reviewed.png
https://i.postimg.cc/63MvyD1r/network-translated.png
https://i.postimg.cc/6q6fPrF0/payment-method-reviewed.png
https://i.postimg.cc/76kV38Vj/payment-method-translated.png
https://i.postimg.cc/44w590hF/settings-reviewed.png
https://i.postimg.cc/RFLTGsph/settings-translated.png
https://i.postimg.cc/TY4JkW0V/trade-apps-reviewed.png
https://i.postimg.cc/9FMBtBdX/trade-apps-translated.png
https://i.postimg.cc/Gp0JRwZ9/user-reviewed.png
https://i.postimg.cc/sgG9bDHt/user-translated.png
https://i.postimg.cc/wvgXt5xp/wallet-reviewed.png
https://i.postimg.cc/TPrjYN60/wallet-translated.png

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@MwithM
Copy link
Contributor

MwithM commented Oct 1, 2024

Thanks for taking care of this.
The wiki compensation policies were thought for a time where automatic translation was not as good as now and translation had to be done 100% manually. Even back then, I thought that it was too expensive, as a professional pricing was used while translators were not professionals. As most of the work is taking care that strings are actually machine translated and they don't require a lot of improvement, I think this is more a dev task than a growth or support task.

I can't tell you how much I think it's ok to ask for compensation, because I have no idea about how much work takes to do the PR's, but it must be significantly less than what you are currently asking for.

I asked hiciefte for help on estimating this CR.

@counterweightoperator
Copy link
Author

Well I understand the rationale and I'm also aware that I kind of decided to take this up on my own, so that's clear. Also clear on the wiki being outdated: I guess I would only advise getting it up to date to make it clear for contributors and avoid further confusions.

On the actual amount, I'll let you guys decide what's reasonable. Being straightforward, you have all the power here. What's done is done. I'll happily take what you decide and update the CR accordingly.

..., I think this is more a dev task than a growth or support task

Would you like me to change the team in the OP from Growth to Dev? Sorry, it's unclear to me if this is what you mean or you're just making a general comment.

@MwithM
Copy link
Contributor

MwithM commented Oct 2, 2024

Leave the team as it is, as I don't have strong arguments into any of both.

@hiciefte
Copy link

hiciefte commented Oct 3, 2024

@counterweightoperator, I recognize that this task required significant effort, but I believe a compensation closer to $500 USD might be more appropriate. I'm not entirely sure how this was handled in the past, as I've only recently started using ChatGPT for translation purposes. While ChatGPT isn't perfect and reviews do add value, I'm uncertain about the exact pricing for this work.

I'm glad that you're willing to take over the Transifex syncing 😅 and translation tasks before each release! We should consider a fair compensation for your future efforts in that regard. Ideally, this process would involve the following steps:

  1. Upload all translation files (or just those that have changes—using tx pull -t will download all translation files and replace untranslated keys with their English source) into the custom ChatGPT I've set up for this purpose.
  2. Interact with ChatGPT until it provides the analyzed and translated files, then download them.
  3. Integrate the translations into your local repository, check for errors, and commit the new translation files.

Initially, there may be some challenges until the custom ChatGPT is fully configured, but eventually, the process should be independent of the number of supported languages—except for the review required for each translation before committing.

Although Bisq typically does not compensate based on effort, perhaps tracking your time on this task for the next release could serve as a starting point for a compensation discussion. IMO, this is more of a development task than a traditional translation task.

@counterweightoperator
Copy link
Author

counterweightoperator commented Oct 3, 2024

Thanks both.

I recognize that this task required significant effort, but I believe a compensation closer to $500 USD might be more appropriate.

Sounds good, I'll adjust the original post with that amount. In case any curious reader is checking this in the future, the original amount was 823.06USD.

I'm glad that you're willing to take over the Transifex syncing 😅 and translation tasks before each release!

Never really mentioned this... but honestly, happy to keep on reviewing when necessary. If I can keep track of when releases are planned I would be happy to focus efforts then.

Although Bisq typically does not compensate based on effort, perhaps tracking your time on this task for the next release could serve as a starting point for a compensation discussion.

I did record the hours I put into this, just didn't put them into the CR since I've generally been advised to not focus on working hours in Bisq's CRs in the past.

In any case, hoping it helps: it was 9.5 hours.

@hiciefte
Copy link

hiciefte commented Oct 7, 2024

Never really mentioned this... but honestly, happy to keep on reviewing when necessary. If I can keep track of when releases are planned I would be happy to focus efforts then.

Ok - then that was kind of a misunderstanding from my side. Shall I downgrade your Transifex permissions to reviewer or do you want to do the Transifex syncing before each release? Maybe I do it for next 2-3 releases myself to be able to fine-tune the custom ChatGPT so it is ready for primetime for someone to take over without too much hassle.

@MwithM MwithM added this to the Cycle 63 milestone Oct 8, 2024
@MwithM MwithM moved this to In Review in Compensation Request Board Oct 8, 2024
@MwithM MwithM mentioned this issue Oct 12, 2024
@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Oct 21, 2024
@MwithM MwithM moved this from Proposal Submitted to In Review in Compensation Request Board Oct 21, 2024
@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Oct 21, 2024
@MwithM
Copy link
Contributor

MwithM commented Oct 21, 2024

Closed as not submitted.

You can re-submit this CR with the updated rates for the cycle 64, which will be announced soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants