Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trade history view #3124

Open
HenrikJannsen opened this issue Jan 22, 2025 · 0 comments
Open

Add trade history view #3124

HenrikJannsen opened this issue Jan 22, 2025 · 0 comments

Comments

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Jan 22, 2025

Bisq Easy did not provide a trade history view to avoid that users keep the trade history forever and leak privacy of their trade peer in case their computer gets compromised.
But the current solution can lead to 2 not desired behavior:

  • Some users might keep the trade open forever to have their trade history present. This leads to bad UX as the trade list gets long.
  • Users might use the export to csv feature and keep that file on their computer forever and by that countering our motivation to protect the peers privacy.

I think its better to add a trade history view where a trade after completion gets moved automatically.
After a certain time (maybe 4 weeks) the peers data in the trade will get deleted automatically to protect their privacy.
For this we would need to tag the log messages with the trade state so that we can find the relevant log messages containing the account data easier. In case users have exchanged in regular chat messages private information we cannot do much. Deleting all chat messages should be considered as well.

See Bisq 1 issue to the topic: bisq-network/bisq#5396 and bisq-network/bisq#6001

@HenrikJannsen HenrikJannsen added this to the 2.1.7 milestone Feb 12, 2025
@HenrikJannsen HenrikJannsen modified the milestones: 2.1.7, 2.1.8 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant