Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger price truncation of prompt text not working #5189

Closed
ripcurlx opened this issue Feb 12, 2021 · 4 comments · Fixed by #6111
Closed

Trigger price truncation of prompt text not working #5189

ripcurlx opened this issue Feb 12, 2021 · 4 comments · Fixed by #6111

Comments

@ripcurlx
Copy link
Contributor

I just recognized in the German translation that the truncation of the new trigger price feature is not configured properly. Also the provided text is not properly translated (I'll take care of this on Transifex myself).

Bildschirmfoto 2021-02-12 um 11 02 44

@forcryptos
Copy link

I am actively exploring the code to make a fix for this, if someone is already working on this, let me know and I will find another issue.

I will be testing most of the fields containing text to see if the do not wrap the inner text.

@ripcurlx
Copy link
Contributor Author

I am actively exploring the code to make a fix for this, if someone is already working on this, let me know and I will find another issue.

I will be testing most of the fields containing text to see if the do not wrap the inner text.

Feel free to take it. Right now I only fixed it by adapting the German translation. But this issue might still exist in other languages.

@alvasw
Copy link
Contributor

alvasw commented Dec 8, 2021

I'm working on this. Just letting everyone know.

@alvasw
Copy link
Contributor

alvasw commented Dec 13, 2021

Sorry, I won't complete this. After chatting with a team member I decided to work on Bisq 2.0.

@alvasw alvasw removed their assignment Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants