Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate offer if market price is above or below a user defined trigger price #4998

Closed
chimp1984 opened this issue Dec 24, 2020 · 1 comment

Comments

@chimp1984
Copy link
Contributor

Description

When using % based price there is a risk that if market price moves too drastically that the offer gets taken to a price which the maker would not like to accept. By adding a trigger price which deactivates the offer automatically if the market price hits that price we can protect makers against such price swings.

If its a sell offer the maker is interested to protect themself against too low prices. If its a buy offer the maker is interested to protect themself against too high prices. So only one field is needed.

Here is a WIP version of the implementation in the create offer view:
Screen Shot 2020-12-23 at 20 29 36

In the open offer view at portfolio we will add a new column for the value and in edit offer it can be changed.

Re-activating the offer once the price exits the undesired range might be an option as well, but is not planned for the initial version.

Please leave comments if you have any inputs/feedback to that feature.

@ripcurlx
Copy link
Contributor

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants