diff --git a/p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java b/p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java index 687d3246c84..c1f54bb4297 100644 --- a/p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java +++ b/p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java @@ -407,9 +407,9 @@ public boolean addProtectedStorageEntry(ProtectedStorageEntry protectedStorageEn boolean hasSequenceNrIncreased = hasSequenceNrIncreased(protectedStorageEntry.getSequenceNumber(), hashOfPayload); // If we have seen a more recent operation for this payload, we ignore the current one - // TODO: I think we can return false here. All callers use the get() public API which increments the sequence number - // leaving only the onMessage() handler which doesn't look at the return value. It makes more intuitive sense that adds() that don't - // change state return false. + // TODO: I think we can return false here. All callers use the Client API (addProtectedStorageEntry(getProtectedStorageEntry()) + // leaving only the onMessage() handler which doesn't look at the return value. It makes more intuitive sense that adds() that don't + // change state return false. if (!hasSequenceNrIncreased) return true; @@ -457,9 +457,9 @@ public boolean refreshTTL(RefreshOfferMessage refreshTTLMessage, int sequenceNumber = refreshTTLMessage.getSequenceNumber(); // If we have seen a more recent operation for this payload, we ignore the current one - // TODO: I think we can return false here. All callers use the get() public API which increments the sequence number - // leaving only the onMessage() handler which doesn't look at the return value. It makes more intuitive sense that operations that don't - // change state return false. + // TODO: I think we can return false here. All callers use the Client API (refreshTTL(getRefreshTTLMessage()) which increments the sequence number + // leaving only the onMessage() handler which doesn't look at the return value. It makes more intuitive sense that operations that don't + // change state return false. if (sequenceNumberMap.containsKey(hashOfPayload) && sequenceNumberMap.get(hashOfPayload).sequenceNr == sequenceNumber) { log.trace("We got that message with that seq nr already from another peer. We ignore that message.");