Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper MSTP support via in-kernel MSTI support #81

Open
7 tasks
KanjiMonster opened this issue Jun 26, 2023 · 0 comments
Open
7 tasks

proper MSTP support via in-kernel MSTI support #81

KanjiMonster opened this issue Jun 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@KanjiMonster
Copy link
Contributor

KanjiMonster commented Jun 26, 2023

Linux recently (in 5.18) added support for defining MSTIs in the kernel as vlan groups for STP (skipping the FID part).

Using that, we can simplify the mstp support, and do not need a stg group per vlan anymore.

To be able to do that, we will require changes in various components:

  • kernel: notify about msti stp changes. Currently these are kept in-kernel, for switchdev only. To allow baseboxd to pick this up we need to have them send out via netlink.
  • libnl: pick up and expose msti stp changes. As above.
  • libnl: pick up expose global vlan options. For baseboxd to know which VIDs are members of which MSTIs, we need to be notified about their membership (changes).
  • baseboxd: pick up and configure MSTs based on the received libnl changes. This will also need a way of knowing if we are in PVSTP or MST mode, as the port STP meaning changes.
  • mstpd: implement setting MSTI memberships for vlans for mst enabled bridges. Will require using similar code like the current PVSTP implementation, as you cannot set port states for non-existing MSTIs, and you can only assign existing vlans to MSTIs.

Additionally, we will also want

  • iproute2: add mst support (apply the patches from https://github.com/wkz/iproute2/tree/mst)
  • systemd-networkd: allow creating bridges in mst enabled mode The mst mode can only be changed when there are no vlans defined on a bridge, so when using systemd-networkd we need to create them in this mode before configuring any vlans.
@KanjiMonster KanjiMonster added the enhancement New feature or request label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant