-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional yen conversion parsing #2000
Comments
Absolutely. We already parse some pretty non-standard numbers and I'm more than happy to add more if they occur in the wild. Do you happen to have any URLs with examples of these variants? |
It's most prevalent on reddit: But you'll sometimes see it on explainer sites in Japanese: To say nothing of the discord chats it sometimes comes up in. It's mostly an English-Japanese speaker thing. |
Thank you! So basically 洋製日本語. Nice. |
@0xNF What is the t suffix used for? |
兆円, I guess?? |
Trillion yen, often seen in discussions of government fiscal budgets. |
Thanks! So I guess "b" should be a suffix too? |
Yeah, I didn't expand in detail in my original comment which is my bad. (m)illion yen Is what I had in mind. |
I've done a basic implementation of this over in #2049 but looking at the dentist thread from an earlier comment I guess it would be more useful if this recognized "5k yen" too? I'm not sure if it's ever going to recognize the "40k" in "40k to 200k円", however, since that would require parsing quite a bit more of the context to make that work. |
Updated #2049 to cover "5k yen" too. |
Thank you! |
In multilingual discussions on the internet, I often encounter yen-denominated sums written with k, m, or t metric suffixes, for example, 40k円, which doesn't parse in 10ten.
What do the maintainers think of allowing these suffixes to be parsed?
The text was updated successfully, but these errors were encountered: