Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese calendar conversion mistakenly recognizes 0年 as 元年 #1912

Closed
SaltfishAmi opened this issue Aug 3, 2024 · 2 comments · Fixed by #1927
Closed

Japanese calendar conversion mistakenly recognizes 0年 as 元年 #1912

SaltfishAmi opened this issue Aug 3, 2024 · 2 comments · Fixed by #1927

Comments

@SaltfishAmi
Copy link
Contributor

SaltfishAmi commented Aug 3, 2024

image

I think this can be very confusing since 元年 is 1年, and we want to avoid mistaking it as 0年.

@birtles
Copy link
Member

birtles commented Aug 13, 2024

Yes, that's a bug. Out of curiosity, did you find content that has 明治0年 in it?

@SaltfishAmi
Copy link
Contributor Author

I think I once found something like 明治0 not necessarily with the 年 suffixed, but still triggered the date conversion

birtles added a commit that referenced this issue Aug 14, 2024
birtles added a commit that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants