-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Hold to Show feature in Safari #818
Comments
Hi @arvin-z! Yes, you're right. The thinking was that if you're in active tab mode, you're probably used to constantly toggling the add-on on and off so you probably don't want to use yet another key to activate the lookup. The hold-to-show key was mostly expected to be used by users who have the add-on enabled all the time and only occasionally activate the lookup. However, if you're using Safari and would find it helpful to have that key we can certainly make it available! |
Thanks for explaining. Hold to Show could perhaps still be helpful because toggling on/off can get tiring when you're constantly doing it on one page, since the Safari shortcut is a bit cumbersome (Cmd+Ctrl+R). |
Thanks for following up on this. In that case, I'll make this available in active tab mode too (note to self: I just need to be careful to make sure it is not available on iOS). |
The Safari version of the plugin doesn't have a Hold to Show option. It seems like it's because the option is hidden in activeTab mode which Safari uses:
10ten-ja-reader/src/config.ts
Lines 636 to 640 in 0d8c86e
Is there a reason Hold to Show can't exist in active tab mode?
The text was updated successfully, but these errors were encountered: