Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up positioning is still off #752

Closed
birtles opened this issue Sep 10, 2021 · 1 comment
Closed

Pop-up positioning is still off #752

birtles opened this issue Sep 10, 2021 · 1 comment

Comments

@birtles
Copy link
Member

birtles commented Sep 10, 2021

I fixed one regression in 6f604ee where we would almost always put the popup below the text in desktop mode even when it would fit above but not below. However, it's still not right.

Here's a screenshot from Slack where the popup should be placed above since you can't scroll down.

image

@birtles
Copy link
Member Author

birtles commented Sep 10, 2021

I've applied a fix for this but it means that on sites like Slack we end up using the horizontal positioning more often.

Although this is working-as-intended, I'm not sure I like it. I wonder if users will find it distracting that the popup can now appear in any which what direction as opposed to simply above or below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant