-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deinflection - recognize continuous form #73
Comments
Yeah, it's a good idea. I've thought about doing it but I seem to recall there being some complications last time I looked into it. It's fairly low priority for me at the moment but I'd gladly take a pull request for it. |
This actually is a lot worse with something like する+ている (ex: 記憶している), because it doesn't even recognize する at all and parses してい as a different word. |
I think it does actually recognize する in している, it's just that there are so many matches for してい first that it gets truncated. Adding support for している would fix it since it is longer and would appear before matches for してい. |
@birtles Nice, thank you very much! I've looked at this initially but quickly realized that I really don't understand your code well enough to confidently make that kind of change. Looking at your commit now, I think I was right. |
Yeah, that code is pretty old. I've rewritten about most of it to be more maintainable, but I still need to mess with spreadsheets and things to work out the numbers each time I touch it. |
Wouldn't it make sense to also consider the -te-iru ending deinflection, e.g.
Currently the te-iru is not being highlighted at all, which leaves out of the visual clue a stray suffix that actually belongs to the verb:
The text was updated successfully, but these errors were encountered: