Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the popup immediately on pressing hold keys #651

Closed
birtles opened this issue Jun 28, 2021 · 0 comments
Closed

Don't show the popup immediately on pressing hold keys #651

birtles opened this issue Jun 28, 2021 · 0 comments

Comments

@birtles
Copy link
Member

birtles commented Jun 28, 2021

Currently, if you have "hold keys" configured (i.e. so you press Alt or Ctrl or both to make the popup show) then the moment you press those keys, if the cursor happens to be over Japanese text, the popup will show.

That might be a good idea sometimes but it trips me up all the time when using Gmail. If I'm composing a mail and press Ctrl + V very often the cursor is hovering over some other Japanese text in the same input box, and the Ctrl press triggers the popup, which triggers the text selection, and I end up clobbering some random text instead.

We should either not do the instantaneous popup when the focus is in a text box, or just not do it at all. The latter might even be as simple as dropping these lines:

if (this.currentPoint && this.currentTarget) {
this.tryToUpdatePopup(this.currentPoint, this.currentTarget, 'default');
ev.preventDefault();
}

I'm a bit afraid this might break things for someone or make it harder to use, however.

@birtles birtles closed this as completed in c9b5cb8 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant