Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the display of name entries more user-friendly #64

Closed
birtles opened this issue Nov 8, 2018 · 6 comments
Closed

Make the display of name entries more user-friendly #64

birtles opened this issue Nov 8, 2018 · 6 comments
Milestone

Comments

@birtles
Copy link
Member

birtles commented Nov 8, 2018

They currently contain things like "(f)" and "(s)" and I can never remember what they mean. We can do better. We could probably do something similar for the "(P)" entries in word entries too.

@birtles birtles added this to the 0.0.27 milestone Nov 8, 2018
@birtles birtles modified the milestones: 0.0.27, 0.0.28 Dec 28, 2018
@nicolasmaia
Copy link

I also have no idea what (uk) means, or what the verb acronyms are.

@birtles
Copy link
Member Author

birtles commented Dec 29, 2018

Yeah, we should do verb annotations too.

@birtles
Copy link
Member Author

birtles commented Dec 29, 2018

I started working on the name handling in the format-names branch. Still to do:

  • Add localization data for the various tags
  • Output the markup for the various tags (probably at the end of the line)
  • CSS styling for the tags (including appropriate colours for each theme)
  • Fix CSS styling when selecting an entry (at least in the blue theme the tag is completely washed out)
  • When copying to the clipboard, re-serialize the tags as appropriate (currently copy entry will produce junk like [Object object] and copy tab-delimited will simply drop the tags)

@birtles
Copy link
Member Author

birtles commented Dec 31, 2018

Alright, this seems to be done now:

Screenshot

And in a localized build:

Screenshot JA

@birtles birtles closed this as completed Dec 31, 2018
@nicolasmaia
Copy link

Looks great!

@birtles
Copy link
Member Author

birtles commented Jan 3, 2019

Thanks! I'd like to do something similar for the word lookup but it might require switching database sources first since I think it's not always possible to reliably separate the definitions using EDICT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants