Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parsing of "ローマじゃない" #49

Closed
nicolasmaia opened this issue Jul 20, 2018 · 7 comments
Closed

Wrong parsing of "ローマじゃない" #49

nicolasmaia opened this issue Jul 20, 2018 · 7 comments
Labels

Comments

@nicolasmaia
Copy link

When parsing ローマじゃないです, Rikaichamp thinks it's looking at ローマ字. This problem can maybe be fixed if you tell the program to never separate じ from ゃ (and other similar cases).

@birtles
Copy link
Member

birtles commented Jul 23, 2018

That's a good idea!

@birtles birtles added the bug label Aug 6, 2018
@nicolasmaia
Copy link
Author

This seems fixed from my end. Did you tweak with it?

@birtles
Copy link
Member

birtles commented Sep 3, 2018

Oh, no I don't know what happened there. I mean, I half rewrote the de-inflection code so that probably fixed it but actually I didn't expect the behavior to change so I'm afraid I might have broken other things in the process.

@birtles
Copy link
Member

birtles commented Sep 5, 2018

git bisect says this was fixed by fa1c7f7 but I have no idea why.

@birtles
Copy link
Member

birtles commented Dec 29, 2018

I'm closing this for now, but I really don't know exactly what fixed it.

@birtles birtles closed this as completed Dec 29, 2018
@neneko
Copy link

neneko commented Jan 3, 2020

This seems to be broken again.

@birtles birtles reopened this Jan 5, 2020
@birtles birtles closed this as completed in ee9f7db Jan 7, 2020
@birtles
Copy link
Member

birtles commented Jan 7, 2020

Should be fixed in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants