Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with fullscreen Netflix #466

Closed
Orzelius opened this issue Dec 10, 2020 · 8 comments
Closed

Not working with fullscreen Netflix #466

Orzelius opened this issue Dec 10, 2020 · 8 comments

Comments

@Orzelius
Copy link

Like the title says, the popup isn't visible on full screen Netflix. Works with youtube though.

Example: (working when not full screen and when full screen the popup is not displayed)
sub

@SaltfishAmi
Copy link
Contributor

Possibly a z-index issue?

@birtles
Copy link
Member

birtles commented Dec 13, 2020

I think the issue here is that the fullscreen API works by taking a specific element and making it occupy the whole screen.

However, the Rikaichamp popup window is attached as a child of the document root element so it will be excluded from full-screen.

In order to fix this I think we'd need to:

  1. Listen for fullscreenchange events on the Document
  2. Move the popup window element to be a child of DocumentOrShadowRoot.fullscreenElement when entering full-screen mode (and restoring it when leaving full-screen mode)

Even then I'm not entirely sure it would work. I think it would be worth trying, however, since Netflix is a pretty worthwhile usecase.

@birtles
Copy link
Member

birtles commented May 26, 2021

I went to look at this today but for me Netflix is rendering subtitles using images.

Specifically I see the following structure for the subtitle content:

image

@Orzelius Has this changed for you too? Or is there some setting I need to tweak?

@Orzelius
Copy link
Author

@birtles sorry for late reply, but I was using an extension to render subtitles as text. The problem still exists for the text displayed in the UI.
image

@nonetrix
Copy link

same here but on animelon seems to just not like full screen?

@birtles
Copy link
Member

birtles commented Apr 21, 2022

What's the name of the extension to render subtitles as text?

@birtles
Copy link
Member

birtles commented Apr 21, 2022

I think getting the popup to show in fullscreen should be possible but if it's not useful for reading subtitles it's probably not worth it.

@Orzelius
Copy link
Author

What's the name of the extension to render subtitles as text?

I think it's this one https://addons.mozilla.org/en-US/firefox/addon/subadub/
(I've since learnt enough Japanese to eliminate the need for it 😋 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants