Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore keyboard shortcuts while a textbox is in focus, even if the popup is for a different element #4

Closed
birtles opened this issue Nov 1, 2017 · 3 comments

Comments

@birtles
Copy link
Member

birtles commented Nov 1, 2017

As requested by @nanaya in #2 (comment)

@nanaya
Copy link

nanaya commented Nov 2, 2017

Actually in my case, having popup when in text focus usually one of these things:

  • accidental mouse movement
  • making sure what input I'm typing on by hovering its label (or just figuring out if it's a series of "type and tab" on long forms)
  • making sure I remember and use word correctly

And there's actually use case of pressing j or k even when not in textbox but still don't want to trigger popup shortcut: the page's shortcut itself (navigating between pages etc).

@birtles
Copy link
Member Author

birtles commented Nov 2, 2017

The first part sounds like this issue. The second part sounds like adding options to customize/disable certain keyboard shortcuts.

@birtles
Copy link
Member Author

birtles commented Mar 12, 2019

Hopefully this is now fixed in the just released 0.0.30.

@birtles birtles closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants