Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rikai doesn't automatically default to names dictionary sometimes #374

Closed
nicolasmaia opened this issue Sep 10, 2020 · 2 comments
Closed

Comments

@nicolasmaia
Copy link

See, for instance 甚三郎

@birtles
Copy link
Member

birtles commented Sep 10, 2020

The logic here (which dates back beyond rikaichamp) is to try the three dictionaries in order:

  1. Words
  2. Kanji
  3. Names

(i.e. the same order they are cycled through when pressing Shift / Enter)

As a result we never actually default to the names dictionary.

That seems wrong though. We should show a match from the names dictionary first even if we preserve the same cycle order. Thanks for the suggestion!

@birtles
Copy link
Member

birtles commented Sep 11, 2020

This actually turns out to be more involved since we don't want to default to the names dictionary if the match is just a single character, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants