Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt + R shortcut conflicts with Edit menu shortcut in Swedish version of Firefox #30

Closed
birtles opened this issue Feb 12, 2018 · 3 comments

Comments

@birtles
Copy link
Member

birtles commented Feb 12, 2018

As reported here: https://birtles.wordpress.com/2017/01/10/web-animation-in-2017/comment-page-1/#comment-1305

Once Firefox bug 1303384 is fixed it will be possible for the user to re-assign these commands themselves, but it might be a long time before that happens.

Perhaps for now we could just add a pref to toggle the Alt + R shortcut and alternatively the previous proposed Alt+6 shortcut?

@birtles
Copy link
Member Author

birtles commented Feb 16, 2018

Oh, nice. Not only has Firefox now got a means to update app shortcuts (as of 6 days ago) but Piro has added a library for it!

@birtles
Copy link
Member Author

birtles commented Aug 23, 2018

This has taken a lot of work but I think I'm nearly done.

key-selection

I've just noticed now, though, that on Windows we don't seem to be calling preventDefault() correctly making it impossible to set e.g.Alt+F11 as the shortcut key.

@birtles birtles added the 0.0.24 label Aug 24, 2018
@birtles
Copy link
Member Author

birtles commented Aug 24, 2018

All the pieces of this are now fixed on master.

@birtles birtles closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant