Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Index issues in iframes #13

Closed
Tomalak opened this issue Nov 16, 2017 · 3 comments
Closed

Z-Index issues in iframes #13

Tomalak opened this issue Nov 16, 2017 · 3 comments

Comments

@Tomalak
Copy link

Tomalak commented Nov 16, 2017

The popup does not appear on top at all times. For example, in Twitter Polls use iframes.

If the text is at the bottom of the iframe, the Rikaichamp window cuts off at the frame border.

Twitter Screenshot

@birtles
Copy link
Member

birtles commented Nov 16, 2017

Yeah, I've noticed that too. That might be a bit tricky to solve. Ideally we'd just run the content script in the top-most window and make it traverse iframe contents but I'm not sure if web extensions have the same security restrictions as regular content does with regard to traversing cross-domain iframes. I suppose we could postMessage from child to parent if necessary but that's still going to be complicated.

@Tomalak
Copy link
Author

Tomalak commented Nov 16, 2017

Yeah, I already figured that. I'm sure it can be solved eventually, but it's gonna be tricky to solve this in a general way. In the case of twitter polls it's not cross-domain at least.

@birtles
Copy link
Member

birtles commented Sep 5, 2018

/cc @InstallGentoo11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants