Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Improve symlink handling with DependencyGraph #4941

Closed
arendjr opened this issue Jan 22, 2025 · 1 comment · Fixed by #4954
Closed

📎 Improve symlink handling with DependencyGraph #4941

arendjr opened this issue Jan 22, 2025 · 1 comment · Fixed by #4954
Assignees
@arendjr

Comments

@arendjr
Copy link
Contributor

arendjr commented Jan 22, 2025 •
edited
Loading

Description

Monorepo setups often use symlinks in their node_modules to link projects to one another. Currently the DependencyGraph doesn’t yet canonicalize paths, so these can lead to duplicate entries for files. If we don’t resolve that, we would likely parse files multiple times and fail to update them properly when the watcher is implemented.

This task involves implementing ResolverCache::canonicalize() in resolver_cache.rs and resolving the FIXME in dependency_graph.tests.rs.
@arendjr arendjr self-assigned this Jan 23, 2025
@arendjr arendjr mentioned this issue Jan 23, 2025
Merged
@arendjr
Copy link
Contributor Author

arendjr commented Jan 24, 2025

Done in #4954.

@arendjr arendjr closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arendjr arendjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): fix symlink handling arendjr/biome
1 participant
@arendjr