Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Replace Clippy allow with expect #3969

Closed
Conaclos opened this issue Sep 18, 2024 · 2 comments · Fixed by #4791
Closed

📎 Replace Clippy allow with expect #3969

Conaclos opened this issue Sep 18, 2024 · 2 comments · Fixed by #4791
Labels
A-Project Area: project good first issue Good for newcomers

Comments

@Conaclos
Copy link
Member

Conaclos commented Sep 18, 2024 •
edited by dyc3
Loading

Description

Rust 1.81 stabilizes Clippy's expect attribute. This attribute ensures that a lint diagnostic is emitted where the attribute appears.

We should replace allow attribute with expect.

We should also retsrict the use of allow by denying clippy::allow_attributes.
@Conaclos Conaclos added good first issue Good for newcomers A-Project Area: project labels Sep 18, 2024
@ematipico
Copy link
Member

I just noticed you don't use 1.81.0 yet, so this task needs to wait until to move to 1.81

@Conaclos
Copy link
Member Author

so this task needs to wait until to move to 1.81

Done in #3972

@fireairforce fireairforce mentioned this issue Sep 19, 2024
Closed
@janie314 janie314 mentioned this issue Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Project Area: project good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@ematipico @Conaclos