Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'useImportType' rule incompatibilty with Angular constructors dependecy injection #2309

Closed
1 task done
vnabet opened this issue Apr 4, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
S-Enhancement Status: Improve an existing feature

Comments

@vnabet
Copy link

vnabet commented Apr 4, 2024

Environment information

CLI:
  Version:                      1.6.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v18.18.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/9.8.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Linter:
  Recommended:                  true
  All:                          false
  Rules:
Workspace:
  Open Documents:               0

Rule name

useImportType

Playground link

https://github.com/vnabet/ng-test-biome

Expected result

'useImportType' rule incompatibilty with Angular constructors dependecy injection

This code is ok for recommended biome rules, but it can't work
Capture d'écran 2024-04-04 170223

Linting error but this code is correct
Capture d'écran 2024-04-04 171026

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos
Copy link
Member

Conaclos commented Apr 4, 2024

Same issue as #2003 and #2261.

We decided to follow the decision of TypeScript ESLint.

@ematipico
Copy link
Member

@Conaclos can we document "this decision" in the rule, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Enhancement Status: Improve an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants