Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› The number of compared files and diagnostics not shown aren't consistent #1201

Closed
1 task done
ematipico opened this issue Dec 15, 2023 · 3 comments
Closed
1 task done
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@ematipico
Copy link
Member

ematipico commented Dec 15, 2023

Environment information

main

What happened?

One run

> biome format --max-diagnostics 0 lib

The number of diagnostics exceeds the number allowed by Biome.
Diagnostics not shown: 577.
Compared 688 file(s) in 97ms
Skipped 1 file(s)
format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  βœ– Some errors were emitted while running checks.


 ELIFECYCLE  Command failed with exit code 1.

Other run

> biome format --max-diagnostics 0 lib

The number of diagnostics exceeds the number allowed by Biome.
Diagnostics not shown: 565.
Compared 665 file(s) in 70ms
format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  βœ– Some errors were emitted while running checks.


 ELIFECYCLE  Command failed with exit code 1.

The numbers seem to be random. This is caused by threads accessing to the resources of process_messages at different times, and the resources aren't locked.

Expected result

The numbers should always be the same at each run.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug labels Dec 15, 2023
@ematipico ematipico changed the title πŸ› The number of compared files and diagnostics not shown isn't consistent πŸ› The number of compared files and diagnostics not shown arent' consistent Dec 15, 2023
@ematipico ematipico changed the title πŸ› The number of compared files and diagnostics not shown arent' consistent πŸ› The number of compared files and diagnostics not shown aren't consistent Dec 15, 2023
@anonrig
Copy link
Contributor

anonrig commented Jan 10, 2024

I'm also seeing the same exact error.

❯ yarn lint:biome
yarn run v1.22.19
$ biome check .
The number of diagnostics exceeds the number allowed by Biome.
Diagnostics not shown: 227.
Checked 2413 file(s) in 3s
Found 1 error(s)
check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  βœ– Some errors were emitted while running checks.


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@Conaclos
Copy link
Member

I think your issue is #1512

@ematipico
Copy link
Member Author

Closing this, I can't replicate it anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

3 participants