terraform-aws-eks tf-0.12 support added #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example usage : we want our nodes to be able to update route53 record
for using external-dns.
```hcl
data "template_file" "eks_worker_additional_route53_policy" {
template = "${file("iam/route53_policy.json.tpl")}"
}
resource "aws_iam_policy" "eks_worker_additional_route53_policy" {
description = "Allow nodes to update our zone"
name = "${module.k8s_cluster01_label.id}-additional-route53-policy"
policy = "${data.template_file.eks_worker_additional_route53_policy.rendered}"
}
```
which defines the policy; then in the EKS module :
```hcl
module "cluster01" {
cluster_name = "cluster01"
<snip>
workers_addtional_policies = [
"${aws_iam_policy.eks_worker_additional_route53_policy.arn}"
]
workers_addtional_policies_count = 1
<snip>
```
* Adding minimum communication The docs at https://docs.aws.amazon.com/eks/latest/userguide/sec-group-reqs.html specify that port 10250 is needed at a minimum for communication between the control plane, and the worker nodes. If you specify a `worker_sg_ingress_from_port` as something like `30000`, then this minimum communication is never established. * Adding description to CHANGELOG.md * Adjusting the naming of the resources * Ensuring creation is conditional on the value of `worker_sg_ingress_from_port` * Mistake, should be greater than port 10250
…_extra_args (#320) * Replacing enable_docker_bridge with a generic option called bootstrap_extra_args * making breaking change more obvious
* Update to 1.12 * Update workers_launch_template.tf * Update local.tf * Update CHANGELOG.md * Update workers.tf * Update workers.tf
* Adding EKS Control Plane logging options * Added feature addition * Removing 'optional' * Adding documentation, and changing variable order * Using pre-commit instead * adding IAM instance profiles to outputs, addresses #323 (#329) * adding IAM instance profiles to outputs * updating changelog * updated README
* Fix: remove ENI's on term fixes cluster destroy issues with security group still attached * Fix: delete ENIs on term to allow sg destroy
Also fixing AWS provider in examples
Signed-off-by: Andrew Roth <[email protected]>
* Switch to https for the pre-commit repos Signed-off-by: Andrew Roth <[email protected]> * Add to changelog Signed-off-by: Andrew Roth <[email protected]> * Undo formatting from prettier plugin Signed-off-by: Andrew Roth <[email protected]>
* Add .prettierignore file Signed-off-by: Andrew Roth <[email protected]> * Add to changelog Signed-off-by: Andrew Roth <[email protected]> * Add missing trailing newline Signed-off-by: Andrew Roth <[email protected]>
* Fixes for Launch Templates * update changelog * add outputs for 3 LT attributes
* Adding doc about spot instances * updating LT worker group details * updating doc
* Adding 2 new outputs: AMI ID and work user-data * adding separate outputs to include both
* allow specifying custom worker IAM instance profiles * allow specifying custom cluster IAM role * add doc * update changelog * use data.aws_iam_instance_profile.name
* cleaning up launch template code * update changelog * Remove variable worker_group_launch_template_tags * misc fixes * fixing and simplifying example
…ed instances policy (#371) * Adding new mixed type of worker group with instance overrides and mixed instances policy * moving all count and lifecycle rule parameters to top/bottom * adding custom IAM parts * updating doc with new options * fixes for spot instances
* adding 3 examples * removing old example * updating PR template * fix this typo * update after renaming default example * add missing launch_template_mixed stuff to aws_auth * fix 2 examples with public subnets * update changelog for new minor release
* Update EBS optimized instances type * Update changelog * Pin terraform version < 0.12
* Adding Worker ASG Option for termination_policies, default set to Default * Adding setting to launch template and mixed * Updated a few more things per PR notes * Change termination_policy default from "Default" to ""
* enable log retention for cloudwatch log groups * revert version bump * set default retention to 90 days
* adds tagging to iam role Signed-off-by: camilo santana <[email protected]> * emulates name_prefix Signed-off-by: camilo santana <[email protected]> * incriment version Signed-off-by: camilo santana <[email protected]> * tags iam role Signed-off-by: camilo santana <[email protected]> * improve resource name Signed-off-by: camilo santana <[email protected]> * removes comments Signed-off-by: camilo santana <[email protected]> * reverts erroneous increment to release version Signed-off-by: camilo santana <[email protected]> * reverts aws_iam_role.cluster name to orig value Signed-off-by: camilo santana <[email protected]> * removes random suffix idea i was using random_id until i could figure out a datestamp or something here. `name_prefix` does a better job. Signed-off-by: camilo santana <[email protected]> * terraform fmt on local.tf Signed-off-by: camilo santana <[email protected]>
* run terraform upgrade tool * fix post upgrade TODOs * use strict typing for variables * upgrade examples, point them at VPC module tf 0.12 PR * remove unnecessary `coalesce()` calls coalesce(lookup(map, key, ""), default) -> lookup(map, key, default) * Fix autoscaling_enabled broken (#1) * always set a value for tags, fix coalescelist calls * always set a value for these tags * fix tag value * fix tag value * default element available * added default value * added a general default without this default - TF is throwing an error when running a destroy * Fix CI * Change vpc module back to `terraform-aws-modules/vpc/aws` in example * Update CHANGELOG.md * Change type of variable `cluster_log_retention_in_days` to number * Remove `xx_count` variables * Actual lists instead of strings with commas * Remove `xx_count` variable from docs * Replace element with list indexing * Change variable `worker_group_tags` to a attribute of worker_group * Fix workers_launch_template_mixed tags * Change override_instance_type_x variables to list. * Update CHANGELOG.md
* New release: now supporting TF 0.12 * updating precommit hook version
* Update to EKS 1.13 * Revert "Pin terraform version < 0.12" This reverts commit 4c71b12. * Update providers in examples and format
* add cloudwatch log group access * update readme for outputs * update outputs * fix formatting * add splat for access to name
diego-ojeda-binbash
approved these changes
Jul 5, 2019
exequielrafaela
pushed a commit
that referenced
this pull request
Jan 30, 2020
…erraform-aws-modules#701) * Configurable local exec command for waiting until cluster is healthy * readme * line feeds * format * fix readme * fix readme * Configurable local exec command for waiting until cluster is healthy (#1) * Configurable local exec command for waiting until cluster is healthy * readme * line feeds * format * fix readme * fix readme * change log * Configurable local exec wait 4 cluster op (#2) * Configurable local exec command for waiting until cluster is healthy * readme * line feeds * format * fix readme * fix readme * change log * changelog (#3) * Changelog (#4) * changelog * changelog * simplify wait_for_cluster command * readme * no op for manage auth false * formatting * docs? not sure * linter * specify dependency to wait for cluster more accurately
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Commits on Jun 19, 2019
Upgrade to terraform 0.12 (Upgrade to terraform 0.12 terraform-aws-modules/terraform-aws-eks#394) …
@nauxliu
@max-rocket-internet
nauxliu and max-rocket-internet
da2c78b
New release: now supporting TF 0.12!! (New release: now supporting TF 0.12!! terraform-aws-modules/terraform-aws-eks#399) …
@max-rocket-internet
max-rocket-internet
9c3d222
Checklist
terraform fmtandterraform validateboth work from the root andexamples/eks_test_fixturedirectories (look in CI for an example)