Skip to content

Commit

Permalink
adds tags to resource aws_iam_role.cluster (terraform-aws-modules#390)
Browse files Browse the repository at this point in the history
* adds tagging to iam role

Signed-off-by: camilo santana <[email protected]>

* emulates name_prefix

Signed-off-by: camilo santana <[email protected]>

* incriment version

Signed-off-by: camilo santana <[email protected]>

* tags iam role

Signed-off-by: camilo santana <[email protected]>

* improve resource name

Signed-off-by: camilo santana <[email protected]>

* removes comments

Signed-off-by: camilo santana <[email protected]>

* reverts erroneous increment to release version

Signed-off-by: camilo santana <[email protected]>

* reverts aws_iam_role.cluster name to orig value

Signed-off-by: camilo santana <[email protected]>

* removes random suffix idea

i was using random_id until i could figure out a datestamp or something here. `name_prefix` does a better job.

Signed-off-by: camilo santana <[email protected]>

* terraform fmt on local.tf

Signed-off-by: camilo santana <[email protected]>
  • Loading branch information
Camilo Santana authored and max-rocket-internet committed Jun 13, 2019
1 parent bf5dae0 commit 3f06015
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ project adheres to [Semantic Versioning](http://semver.org/).

- Added Termination Policy Option to worker ASGs (by @undeadops)
- Update EBS optimized instances type (by @gloutsch)
- Added tagging for iam role created in `./cluster.tf` (@camilosantana)
- Enable log retention for cloudwatch log groups (by @yuriipolishchuk)


### Changed

- Fix toggle for IAM instance profile creation for mixed launch templates (by @jnozo)
Expand Down
1 change: 1 addition & 0 deletions cluster.tf
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ resource "aws_iam_role" "cluster" {
permissions_boundary = "${var.permissions_boundary}"
path = "${var.iam_path}"
force_detach_policies = true
tags = "${var.tags}"
}

resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSClusterPolicy" {
Expand Down

0 comments on commit 3f06015

Please sign in to comment.