fix(av-canvas): 精灵操作适配移动端 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b257f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@litt1eXixi 感谢勇士的贡献。 请检查修复单测错误，也请确保新事件能完整兼容 PC 端的鼠标操作。 另外参考请参考贡献指南 - 工作流 , 添加 changeset 文件。 |
感谢你的回复与提醒，此前并未注意到单元测试的错误，由于我是使用了pointer事件替代鼠标事件，自测的过程中可以完整的兼容PC端的操作，在单侧中仅提供了mouse事件的相关用例，是否允许我修改对应的单侧代码，更新对应测试的内容 |
|
@litt1eXixi 确保 pointer 事件能兼容 PC 端鼠标操作后，可以将单测中的对应的事件名称改成 pointer。 |
|
好的，已修改对应的内容，再次感谢你的耐心，这是我第一次为开源项目贡献代码，对于流程疏忽之处烦请见谅 |
|
太棒了，恭喜你解锁了新成就！ 加油～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将mouse事件替换为pointer事件，同时在创建canvas的时候增加touch-action: none
以适配移动端操作