feat(common): PAYPAL-7 Pass in merchant ID on PayPal button script fo…

…r PayPal Express Checkout - CR fixes
bigcommerce · Oct 22, 2019 · bdfbcd5 · bdfbcd5
1 parent fc9e7c9
commit bdfbcd5
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/script-loader.ts b/src/script-loader.ts
@@ -31,14 +31,12 @@ export default class ScriptLoader {
         if (!this._scripts[src]) {
             this._scripts[src] = new Promise((resolve, reject) => {
                 const script = document.createElement('script') as LegacyHTMLScriptElement;
-                const { async = false } = options || {};
-                const scriptAttributes = options && options.attributes;
+                const { async = false, attributes = {} } = options || {};
 
-                for (const key in scriptAttributes) {
-                    if (scriptAttributes.hasOwnProperty(key)) {
-                        script.setAttribute(key, scriptAttributes[key]);
-                    }
-                }
+                Object.keys(attributes)
+                    .forEach(key => {
+                        script.setAttribute(key, attributes[key]);
+                    });
 
                 script.onload = () => resolve();
                 script.onreadystatechange = () => resolve();