Skip to content

Commit

Permalink
fix(payments): PAYMENTS-3064 Use deviceSessionId from payment
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack Dinh committed Jul 5, 2018
1 parent e4574ed commit d41ea18
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
3 changes: 1 addition & 2 deletions src/payment/v1/payment-mappers/payment-mapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ export default class PaymentMapper {
orderMeta = {},
payment = {},
paymentMethod = {},
quoteMeta = {},
} = data;

const payload = {
device_info: quoteMeta.request ? quoteMeta.request.deviceSessionId : null,
device_info: payment.deviceSessionId ? payment.deviceSessionId : null,
device: orderMeta.deviceFingerprint ? { fingerprint_id: orderMeta.deviceFingerprint } : null,
gateway: this.paymentMethodIdMapper.mapToId(paymentMethod),
notify_url: order.callbackUrl,
Expand Down
1 change: 1 addition & 0 deletions test/mocks/payment-request-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ const paymentRequestDataMock = {
ccName: 'Foo Bar',
ccNumber: '4007000000027',
ccCustomerCode: 'XYZ',
deviceSessionId: 'fakeDeviceSessionId',
extraData: { test: 'data' },
shouldSaveInstrument: false,
},
Expand Down
10 changes: 5 additions & 5 deletions test/payment/v1/payment-mappers/payment-mapper.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('PaymentMapper', () => {
device: {
fingerprint_id: data.orderMeta.deviceFingerprint,
},
device_info: data.quoteMeta.request.deviceSessionId,
device_info: data.payment.deviceSessionId,
gateway: data.paymentMethod.id,
notify_url: data.order.callbackUrl,
return_url: data.paymentMethod.returnUrl,
Expand All @@ -66,7 +66,7 @@ describe('PaymentMapper', () => {
device: {
fingerprint_id: data.orderMeta.deviceFingerprint,
},
device_info: data.quoteMeta.request.deviceSessionId,
device_info: data.payment.deviceSessionId,
gateway: data.paymentMethod.id,
notify_url: data.order.callbackUrl,
return_url: data.paymentMethod.returnUrl,
Expand All @@ -92,7 +92,7 @@ describe('PaymentMapper', () => {
device: {
fingerprint_id: data.orderMeta.deviceFingerprint,
},
device_info: data.quoteMeta.request.deviceSessionId,
device_info: data.payment.deviceSessionId,
gateway: data.paymentMethod.id,
notify_url: data.order.callbackUrl,
return_url: data.paymentMethod.returnUrl,
Expand Down Expand Up @@ -129,7 +129,7 @@ describe('PaymentMapper', () => {
device: {
fingerprint_id: data.orderMeta.deviceFingerprint,
},
device_info: data.quoteMeta.request.deviceSessionId,
device_info: data.payment.deviceSessionId,
gateway: data.paymentMethod.id,
notify_url: data.order.callbackUrl,
return_url: data.paymentMethod.returnUrl,
Expand Down Expand Up @@ -161,7 +161,7 @@ describe('PaymentMapper', () => {
device: {
fingerprint_id: data.orderMeta.deviceFingerprint,
},
device_info: data.quoteMeta.request.deviceSessionId,
device_info: data.payment.deviceSessionId,
gateway: data.paymentMethod.id,
notify_url: data.order.callbackUrl,
return_url: data.paymentMethod.returnUrl,
Expand Down

0 comments on commit d41ea18

Please sign in to comment.