-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining formatting issues in tables #746
Comments
just noticed a similar "formatting" related PR: #786 I think if we don't put CIs into place to catch these soft, style related things, it'll be hard to maintain. |
Agreed. Though regarding the CI part we have to keep in mind that possibly a lot of this will be "encoded" in the metadata part of the awesome schema that @tsalo is working on. So the style check will probably have to be done on some intermediate files after the macros are applied, no? I think you did some similar magic recently, am I right? |
Indeed, and I think between Taylor and me we managed to purge a few more styling "bugs".
Yes, since #774 these kinds of styling "bugs" would have to be fixed in the schema files ... OR on the spec after the schema is applied. --> But I think running a CI on the YAML file "descriptions" would be nicer: bids-specification/src/schema/metadata/Acknowledgements.yaml Lines 3 to 5 in 87ca2c1
We just need someone to spend a couple of "minutes to hours"™ to write a script and a GitHub Action to run it 😎 EDIT: I think this is starting to become too technical for a "good first issue" |
2 other issues I have noticed that make my inner OCD unhappy:
inconsistency in the format of the table headers in the spec: most of the time it is in bold but not alwaysFor example
Should probably be:
Sometimes examples are written:
and other times
V
for Volt, orfT/cm
for femto Tesla per centimeter (see Units).Originally posted by @Remi-Gau in #739 (comment)
The text was updated successfully, but these errors were encountered: