-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markers suffix for MEG only referenced in Appendix VI #638
Comments
Indeed a badly defined suffix, it could have been I think this requires input from a Yokogawa/Ricoh MEG user. |
Just to improve the information state a bit:
problems:
potential solution:
cc @jasmainak @hoechenberger @agramfort also tagging @teonbrooks because I think to remember that he knows a bit more about kit than other people? |
+1 on doing exactly this. |
I also agree that |
+1 |
Removing the However the alternative that we probably should go with is to deprecate the |
Quickly read the issue but is the proposed solution compatible with multiple marker files? It reminded me of this old issue: |
From what I remember the |
@jasmainak is correct, I forgot about that. I was looking through the spec and couldn't find a full list of suffixes anywhere. is there a list of them as there are for the entities? Is there a place where we should be surfacing suffixes? |
@teonbrooks The primary location is the relevant "modality-specific files" page(s) where the suffix can be used, but I am also working on a schema version of the specification wherein suffixes should all be represented. |
perhaps we should then swallow the bitter pill and properly introduce the |
@sappelhoff, should we update the entity list? |
yes! That'll be done automatically in #610 "markers" are added to the BIDS schema here --> https://github.com/bids-standard/bids-specification/blob/84fdf30c2c011c2928f2d78085f603772b9c82df/src/schema/datatypes/meg.yaml and the entity table will be created automatically from the schema EDIT: I just assumed you meant "entity table" with your "entity list" --> the actual entity list would not list markers, because it's not an entity |
sorry, my bad, I meant suffix, not entity. and cool! 🎉 |
The
_markers
suffix for MEG data is present in Appendix VI and the Entity Table, but there is no definition for it anywhere, as far as I can tell. @bids-standard/raw-electrophys-meg does anyone know what this suffix refers to and can we define it in the main text?Stems from #610:
Originally posted by @sappelhoff in #610 (comment)
The text was updated successfully, but these errors were encountered: