update readme to reflect the availibility of both freesurder 6 and 7

[Remi-Gau]

No description provided.

[Shotgunosine]

I snuck a small readme update in on my PR:

freesurfer/README.md

Lines 5 to 8 in 4663559

	creates a study specific template. In case there are multiple sessions the Freesurfer longitudinal pipeline is used (creating subject specific templates) unless instructed to combine data across sessions. This app is available for both Freesurfer 6 and 7.
	The current Freesurfer version for Freesurfer 6 is based on: freesurfer-Linux-centos6_x86_64-stable-pub-v6.0.1.tar.gz
	The current Freesurfer version for Freesurfer 7 is based on: freesurfer-linux-centos7_x86_64-7.4.1.tar.gz

Is there more you want to say about it?

[Remi-Gau]

yeah I just want to be clear what will happen it people do

docker run -ti --rm bids/freesurfer

or

docker run -ti --rm bids/freesurfer:latest

[Remi-Gau]

OK that's I thought / feared:

we now have 2 repos on dockerhub with ugly names:

https://hub.docker.com/r/bids/freesurfer_fs7
https://hub.docker.com/r/bids/freesurfer_fs6

even worse the tags for fs6 mention version 7.4:
https://hub.docker.com/r/bids/freesurfer_fs6/tags

this is going to be super confusing

should we say that all images get pushed to https://hub.docker.com/r/bids/freesurfer

docker pull bids/freesurfer and docker pull bids/freesurfer:latest should be the same as
docker pull bids/freesurfer:v7.4.1

@Shotgunosine WDYT?

[Shotgunosine]

This seems fixable with some conditional logic in the deploy job. Where does ${CIRCLE_TAG} come from?

docker pull bids/freesurfer and docker pull bids/freesurfer:latest should be the same as
docker pull bids/freesurfer:v7.4.1

I agree, docker pull bids/freesurfer:v6.0.1 and/or docker pull bids/freesufer:v6 should be required to get freesurfer 6. Though I suppose that could be suprising for people who currently docker pull bids/freesurfer and expect to get freesurfer 6. Was the freesurfer bids app available that way? Should we have a deprecation warning period or something?

[Shotgunosine]

Are you able to see usage stats here: https://hub.docker.com/r/bids/freesurfer/tags? Is docker pull bids/freesurfer still being run frequently? If so, I would keep freesurfer 6 as the default for now and leave 7 at the freesurfer:v7.4.1 tag. We could modify the run.py to add a message about freesurfer 7 availability?

[Remi-Gau]

don't have access to the frequency of the pulls. only the total number:

[Remi-Gau]

Where does ${CIRCLE_TAG} come from?

this is the tag value you give to the tagged release :

https://github.com/bids-apps/freesurfer/releases/tag/v7.4.1

Should we have a deprecation warning period or something?

yes but for not more than 6 months - 1 year

We could modify the run.py to add a message about freesurfer 7 availability?

yes and also warning about the fact that "latest" will move to be freesurfer 7 "soon"

[Remi-Gau]

closed by #77