Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue of GSP-41: Turn Pair Expire into Duration #676

Closed
4 tasks done
Xuanwo opened this issue Jul 16, 2021 · 2 comments
Closed
4 tasks done

Tracking issue of GSP-41: Turn Pair Expire into Duration #676

Xuanwo opened this issue Jul 16, 2021 · 2 comments
Assignees
@aeinrw
Labels
good first issue Issue template help wanted

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 16, 2021 •
edited by Prnyself
Loading

This is a special case: we will change the type of our global pairs.

At the time we proposal the GSP-41, only one service(qingstor) implement Reach and depends on expire.

Affected Services

  • qingstor

Steps

  • Add support for time.Duration (Update cmd/definitions/tmpl/service.tmpl to import time package)
  • Change pair type from int to time.Duration (Update definitions/pairs.toml pair's type)
  • All services that refer to expire change to expire instead (Rebuild with new go-storage)
@Xuanwo Xuanwo added good first issue Issue template help wanted and removed good first issue Issue template labels Jul 16, 2021
@Xuanwo Xuanwo mentioned this issue Jul 19, 2021
Closed
@aeinrw aeinrw mentioned this issue Jul 19, 2021
Merged
@Prnyself
Copy link
Member

Prnyself commented Jul 20, 2021 •
edited
Loading

@aeinrw Since #681 is merged, could you please implement this change into go-service-qingstor? The related steps are list here.

@aeinrw aeinrw mentioned this issue Jul 22, 2021
Merged
@Prnyself
Copy link
Member

Good job! @aeinrw

@Xuanwo Xuanwo mentioned this issue Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeinrw aeinrw

Labels
good first issue Issue template help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuanwo @Prnyself @aeinrw